feat: dot auto-completion for most occurrences of global identifiers #8424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release-ci
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 21, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 21, 2025
leanprover-community-bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
Rob23oba
requested review from
digama0,
mhuisi,
leodemoura and
kim-em
as code owners
github-actions
bot
added
the
changelog-language
leanprover-community-bot
added
builds-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 24, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 24, 2025
eric-wieser
reviewed
May 25, 2025
Comment on lines
-22
to
-23
| syntax grindBwd := "← " <|> "-> " | ||
| syntax grindFwd := "→ " <|> "<- " |
There was a problem hiding this comment.
This is surely worth its own PR!
There was a problem hiding this comment.
Well I'd rather do bootstrapping once with an unrelated fix than do it twice because of such a small change...
There was a problem hiding this comment.
I thought CI did bootstrapping automatically these days
There was a problem hiding this comment.
Oh no I mean I need to do things after a stage0 update to complete the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds dot auto-completion to many syntactic constructions, including e.g.
#printorunfold. A follow-up PR will be necessary for bootstrapping.Closes #8353